misc: chore: Use collection expressions (part 2)

src/Ryujinx/Input/AvaloniaKeyboard.cs

@@ -38,7 +38,7 @@ namespace Ryujinx.Ava.Input
 
         public AvaloniaKeyboard(AvaloniaKeyboardDriver driver, string id, string name)
         {
-            _buttonsUserMapping = new List<ButtonMappingEntry>();
+            _buttonsUserMapping = [];
 
             _driver = driver;
             Id = id;

src/Ryujinx/UI/Controls/ApplicationContextMenu.axaml.cs

@@ -173,7 +173,7 @@ namespace Ryujinx.Ava.UI.Controls
                     DirectoryInfo mainDir = new(Path.Combine(AppDataManager.GamesDirPath, viewModel.SelectedApplication.IdString, "cache", "cpu", "0"));
                     DirectoryInfo backupDir = new(Path.Combine(AppDataManager.GamesDirPath, viewModel.SelectedApplication.IdString, "cache", "cpu", "1"));
 
-                    List<FileInfo> cacheFiles = new();
+                    List<FileInfo> cacheFiles = [];
 
                     if (mainDir.Exists)
                     {
@@ -218,7 +218,7 @@ namespace Ryujinx.Ava.UI.Controls
                 DirectoryInfo mainDir = new(Path.Combine(AppDataManager.GamesDirPath, viewModel.SelectedApplication.IdString, "cache", "cpu", "0"));
                 DirectoryInfo backupDir = new(Path.Combine(AppDataManager.GamesDirPath, viewModel.SelectedApplication.IdString, "cache", "cpu", "1"));
 
-                List<FileInfo> cacheFiles = new();
+                List<FileInfo> cacheFiles = [];
 
                 if (mainDir.Exists)
                 {
@@ -266,8 +266,8 @@ namespace Ryujinx.Ava.UI.Controls
                 {
                     DirectoryInfo shaderCacheDir = new(Path.Combine(AppDataManager.GamesDirPath, viewModel.SelectedApplication.IdString, "cache", "shader"));
 
-                    List<DirectoryInfo> oldCacheDirectories = new();
-                    List<FileInfo> newCacheFiles = new();
+                    List<DirectoryInfo> oldCacheDirectories = [];
+                    List<FileInfo> newCacheFiles = [];
 
                     if (shaderCacheDir.Exists)
                     {

src/Ryujinx/UI/Controls/NavigationDialogHost.axaml.cs

@@ -124,7 +124,7 @@ namespace Ryujinx.Ava.UI.Controls
 
             Span<SaveDataInfo> saveDataInfo = stackalloc SaveDataInfo[10];
 
-            HashSet<UserId> lostAccounts = new();
+            HashSet<UserId> lostAccounts = [];
 
             while (true)
             {

src/Ryujinx/UI/Models/CheatNode.cs

@@ -8,7 +8,7 @@ namespace Ryujinx.Ava.UI.Models
     public class CheatNode : BaseModel
     {
         private bool _isEnabled = false;
-        public ObservableCollection<CheatNode> SubNodes { get; } = new();
+        public ObservableCollection<CheatNode> SubNodes { get; } = [];
         public string CleanName => Name.Length > 0 ? Name[1..^7] : Name;
         public string BuildIdKey => $"{BuildId}-{Name}";
         public bool IsRootNode { get; }

src/Ryujinx/UI/ViewModels/AmiiboWindowViewModel.cs

@@ -61,9 +61,9 @@ namespace Ryujinx.Ava.UI.ViewModels
             Directory.CreateDirectory(Path.Join(AppDataManager.BaseDirPath, "system", "amiibo"));
 
             _amiiboJsonPath = Path.Join(AppDataManager.BaseDirPath, "system", "amiibo", "Amiibo.json");
-            _amiiboList = new List<AmiiboApi>();
-            _amiiboSeries = new ObservableCollection<string>();
-            _amiibos = new AvaloniaList<AmiiboApi>();
+            _amiiboList = [];
+            _amiiboSeries = [];
+            _amiibos = [];
 
             _amiiboLogoBytes = EmbeddedResources.Read("Ryujinx.UI.Common/Resources/Logo_Amiibo.png");
 

src/Ryujinx/UI/ViewModels/ModManagerViewModel.cs

@@ -23,9 +23,9 @@ namespace Ryujinx.Ava.UI.ViewModels
     {
         private readonly string _modJsonPath;
 
-        private AvaloniaList<ModModel> _mods = new();
-        private AvaloniaList<ModModel> _views = new();
-        private AvaloniaList<ModModel> _selectedMods = new();
+        private AvaloniaList<ModModel> _mods = [];
+        private AvaloniaList<ModModel> _views = [];
+        private AvaloniaList<ModModel> _selectedMods = [];
 
         private string _search;
         private readonly ulong _applicationId;

src/Ryujinx/UI/ViewModels/SettingsViewModel.cs

@@ -390,11 +390,11 @@ namespace Ryujinx.Ava.UI.ViewModels
 
         public SettingsViewModel()
         {
-            GameDirectories = new AvaloniaList<string>();
-            AutoloadDirectories = new AvaloniaList<string>();
-            TimeZones = new AvaloniaList<TimeZone>();
-            AvailableGpus = new ObservableCollection<ComboBoxItem>();
-            _validTzRegions = new List<string>();
+            GameDirectories = [];
+            AutoloadDirectories = [];
+            TimeZones = [];
+            AvailableGpus = [];
+            _validTzRegions = [];
             _networkInterfaces = new Dictionary<string, string>();
 
             Task.Run(CheckSoundBackends);

src/Ryujinx/UI/ViewModels/UserFirmwareAvatarSelectorViewModel.cs

@@ -31,7 +31,7 @@ namespace Ryujinx.Ava.UI.ViewModels
 
         public UserFirmwareAvatarSelectorViewModel()
         {
-            _images = new ObservableCollection<ProfileImageModel>();
+            _images = [];
 
             LoadImagesFromStore();
         }

src/Ryujinx/UI/ViewModels/UserProfileViewModel.cs

@@ -9,8 +9,8 @@ namespace Ryujinx.Ava.UI.ViewModels
     {
         public UserProfileViewModel()
         {
-            Profiles = new ObservableCollection<BaseModel>();
-            LostProfiles = new ObservableCollection<UserProfile>();
+            Profiles = [];
+            LostProfiles = [];
             IsEmpty = !LostProfiles.Any();
         }
 

src/Ryujinx/UI/ViewModels/UserSaveManagerViewModel.cs

@@ -13,8 +13,8 @@ namespace Ryujinx.Ava.UI.ViewModels
         private int _sortIndex;
         private int _orderIndex;
         private string _search;
-        private ObservableCollection<SaveModel> _saves = new();
-        private ObservableCollection<SaveModel> _views = new();
+        private ObservableCollection<SaveModel> _saves = [];
+        private ObservableCollection<SaveModel> _views = [];
         private readonly AccountManager _accountManager;
 
         public string SaveManagerHeading => LocaleManager.Instance.UpdateAndGetDynamicValue(LocaleKeys.SaveManagerHeading, _accountManager.LastOpenedUser.Name, _accountManager.LastOpenedUser.UserId);

src/Ryujinx/UI/ViewModels/XCITrimmerViewModel.cs

@@ -35,9 +35,9 @@ namespace Ryujinx.Ava.UI.ViewModels
         private readonly Ryujinx.Common.Logging.XCIFileTrimmerLog _logger;
         private readonly ApplicationLibrary _applicationLibrary;
         private Optional<XCITrimmerFileModel> _processingApplication = null;
-        private AvaloniaList<XCITrimmerFileModel> _allXCIFiles = new();
-        private AvaloniaList<XCITrimmerFileModel> _selectedXCIFiles = new();
-        private AvaloniaList<XCITrimmerFileModel> _displayedXCIFiles = new();
+        private AvaloniaList<XCITrimmerFileModel> _allXCIFiles = [];
+        private AvaloniaList<XCITrimmerFileModel> _selectedXCIFiles = [];
+        private AvaloniaList<XCITrimmerFileModel> _displayedXCIFiles = [];
         private MainWindowViewModel _mainWindowViewModel;
         private CancellationTokenSource _cancellationTokenSource;
         private string _search;
@@ -538,4 +538,4 @@ namespace Ryujinx.Ava.UI.ViewModels
             }
         }
     }
-}
+}

src/Ryujinx/UI/Views/Main/MainMenuBarView.axaml.cs

@@ -38,7 +38,7 @@ namespace Ryujinx.Ava.UI.Views.Main
 
         private CheckBox[] GenerateToggleFileTypeItems()
         {
-            List<CheckBox> checkBoxes = new();
+            List<CheckBox> checkBoxes = [];
 
             foreach (var item in Enum.GetValues(typeof(FileTypes)))
             {
@@ -56,7 +56,7 @@ namespace Ryujinx.Ava.UI.Views.Main
 
         private static MenuItem[] GenerateLanguageMenuItems()
         {
-            List<MenuItem> menuItems = new();
+            List<MenuItem> menuItems = [];
 
             string localePath = "Ryujinx/Assets/Locales";
             string localeExt = ".json";